Skip to content

Conversation

MasonProtter
Copy link
Contributor

@MasonProtter MasonProtter commented Jan 15, 2024

Tests pass for me locally if I fix the problems caused by JuliaDiff/ChainRules.jl#769 by manually defining methods for one and zero.


Edit: oops, I messed up when testing locally, there is more work to do here to accomidate AbstractDiff 0.6

@mcabbott
Copy link
Member

Dup of #228?

@gdalle
Copy link
Member

gdalle commented Jan 16, 2024

yeah, apparently the change is breaking in more subtle ways, closing in favor of the PR where @oxinabox was working

@gdalle gdalle closed this Jan 16, 2024
@MasonProtter
Copy link
Contributor Author

Oops dont know how I missed that PR 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants